Skip to content

[clang] Add Swift support for MIPS #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: swift/next
Choose a base branch
from

Conversation

colemancda
Copy link

@colemancda colemancda commented Mar 6, 2022

Adds support for compiling Swift targeting the MIPS ABI

Differential Revision: https://reviews.llvm.org/D137512

Resolves SR-15943

@CodaFi
Copy link

CodaFi commented Mar 7, 2022

Does this have a corresponding LLVM patch up for review?

@colemancda
Copy link
Author

No, sorry.

@CodaFi
Copy link

CodaFi commented Mar 7, 2022

I would ask that you upstream these. The next branch here is intended to be a staging area for commits that come directly from LLVM before we settle on a stable version. In general, we merge Swift-specific commits into the stable branch (which, as of this writing is stable/20211026) and make good faith effort to upstream these patches so they are automatically included in next when we retag things.

@colemancda colemancda changed the title Added SwiftABIInfo support for MIPS [clang] Add Swift support for MIPS Nov 7, 2022
Adds support for compiling Swift targeting the MIPS ABI

Differential Revision: https://reviews.llvm.org/D137512
@colemancda
Copy link
Author

colemancda commented Nov 7, 2022

@CodaFi Any suggestions on who I should contact at LLVM or assign to get this merged?

https://reviews.llvm.org/D137512

@CodaFi
Copy link

CodaFi commented Nov 8, 2022

I will ping maintainers about this tomorrow morning. This looks pretty good to me, but I'm far from the expert in Clang infra we have for different target infos.

@CodaFi
Copy link

CodaFi commented Nov 8, 2022

@swift-ci test

@aschwaighofer
Copy link

Can you rebase https://reviews.llvm.org/D137512 on top of github.com:apple/llvm-project.git's main?

@colemancda
Copy link
Author

@aschwaighofer Rebased off github.com:apple/llvm-project.git llvm.org/main branch. There is no main branch in that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants